Skip to content
This repository has been archived by the owner on Sep 30, 2023. It is now read-only.

chore: Add npm maintainers #20

Merged
merged 3 commits into from
Apr 2, 2019
Merged

chore: Add npm maintainers #20

merged 3 commits into from
Apr 2, 2019

Conversation

RichardLitt
Copy link
Contributor

This adds a maintainers field to the package.json. Ideally, someone else should be in this field, too. Please add another contributor as a maintainer for this npm package, such as @shamb0t, by typing: npm owner add @shamb0t. Then, add them to the maintainers field in this PR, or ping me to do it. Thank you.

This adds a maintainers field to the package.json. Ideally, someone else should be in this field, too. Please add another contributor as a maintainer for this npm package, such as @shamb0t, by typing: `npm owner add @shamb0t`. Then, add them to the maintainers field in this PR, or ping me to do it. Thank you.
@RichardLitt
Copy link
Contributor Author

RichardLitt commented Mar 26, 2019

Hold off on this. There's an issue with inconsistent docs for npm's package.json. Looking into it.

@RichardLitt RichardLitt assigned RichardLitt and unassigned haadcode Mar 26, 2019
In keeping with orbitdb-archive/welcome#55, I add an orbitdb field here. I also suggest @shamb0t as an extra maintainer, as she is already a contributor here. When this is merged, she should be added.
@RichardLitt RichardLitt assigned haadcode and unassigned RichardLitt Mar 27, 2019
@RichardLitt
Copy link
Contributor Author

Figured out a workaround. In keeping with orbitdb-archive/welcome#55, I add an orbitdb field here. I also suggest @shamb0t as an extra maintainer, as she is already a contributor here. When this is merged, she should be added.

@haadcode Let me know if this works. If it does, I'll go through and do similar PRs to the rest of the org.

@aphelionz
Copy link

In this, is the orbitdb key arbitrary or does that map to an npm org?

@RichardLitt
Copy link
Contributor Author

It's arbitrary. It's just for us to use. maintainer and maintainers at the top-level might be an issue.

@aphelionz
Copy link

How is the array of names in orbitdb.maintainers consumed on the NPM side?

@RichardLitt
Copy link
Contributor Author

It isn't. I'd like to build a tool to check the veracity of the maintainers list against the npm info output. For lack of a better space, I opened an issue about that here: orbitdb/repo-template#6. For now, I'd manually check it.

@aphelionz
Copy link

aha! ok. Then go wild, my friend

@shamb0t
Copy link
Contributor

shamb0t commented Mar 28, 2019

LGTM 👍

@haadcode
Copy link
Member

haadcode commented Apr 2, 2019

Updated my email, good to go 👍

@haadcode haadcode merged commit cdbf287 into master Apr 2, 2019
@haadcode haadcode deleted the feat/maintainers branch April 2, 2019 09:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants